Skip to content

Conversation

@Helmsdown
Copy link
Contributor

Added a unit test class since there was no test for user use cases. Solves #232

aheritier
aheritier previously approved these changes Aug 27, 2020
Copy link
Contributor

@aheritier aheritier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for your contribution @Helmsdown

@Helmsdown
Copy link
Contributor Author

Helmsdown commented Aug 27, 2020

https://www.youtube.com/watch?v=pYL6g_Dw_4U ;-)

@aheritier
Copy link
Contributor

I am merging it. I also merged some PRs I did several months ago.
Some of them are introducing some breaking changes but for a good reason (to fix some invalid code)

@aheritier aheritier merged commit 628a56b into cloudbees-oss:master Aug 27, 2020
@aheritier aheritier added this to the 0.14.0 milestone Aug 27, 2020
@Helmsdown
Copy link
Contributor Author

When do you expect to release again?

@Helmsdown Helmsdown deleted the merge-users branch August 27, 2020 19:24
@aheritier
Copy link
Contributor

I can do it soon @Helmsdown
I am trying to have our build restored. We lost them because of the move to a different GH org.
If we validate the dependency updates on the CI I can merge them too and launch a release this week

@Helmsdown
Copy link
Contributor Author

Most appreciated. Thank you for your swift response.

@aheritier
Copy link
Contributor

with pleasure @Helmsdown

@aheritier
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants