Add various "Many" create/update/delete methods #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deleted tickets. It shouldn't call `deleteTickets` which is not necessarily immediate.
…deleted tickets. It shouldn't call `deleteTicket` which is not necessarily immediate.
Otherwise we have randomly Integer or Long based on the value and it's impossible to manage them efficiently in Java
This was
linked to
issues
May 31, 2020
|
There is a permission issue on this repo and at least @johnou is not in the committer list anymore. I am checking with our OPS what was done. |
This was referenced May 31, 2020
…ke tickets, users, orgs, ... Add several new integration test cases to validate the behavior.
aheritier
force-pushed
the
create_or_update_many
branch
from
3d07576 to
938302f
Compare
|
No review in 3 months, .... it's probably ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve: #47 #96 #98 #245 #324 #325
Also #250 partially (more tests to improve)
deleteOrganizationMembershipsmethodcreateOrganizationMembershipsmethodsupdateOrganizationsmethodsupdateUsersmethodscreateOrUpdateUsersmethodspermanentlyDeleteTicket(s)methods aren't calling anymoredeleteTicket(s)because the deletion must be acked (and it's not necessarily immediate) before deleting them permanently