Introduce cider-ignored-error-phases

[vemv]

Commits:

• Use cider-nrepl 0.36.0
  • Supports this PR, and also broadens the semantics of the tooling filter:

• Introduce cider-ignored-error-phases
  • Fixes cider-show-error-buffer/cider-auto-jump-to-error: honor :clojure.error/phase #3418
• cider-auto-jump-to-error: also recognise macroexpansion errors
  • Mostly unrelated, but also very small.

QA

This PR's main focus is easy to QA:

• (setq cider-show-error-buffer 'always)
• enter an invalid token like ::::a in the REPL
  • no stacktrace will show up, a concise message will be printed at the repl
• enter an invalid macroexpansion like (let [1]) in the REPL
  • no stacktrace will show up, a concise message will be printed at the repl
• enter an expr that will cause a runtime exception like (/ 2 0)
  • the *cider-error* buffer will show up
  • if the tooling filter is on, notably few stack frames will be visible
  • the usual output will also be visible at the REPL output.

Cheers - V

[vemv]

@yuhan0 : feel free to review this one, I reckon it might interest you

[bbatsov]

I think this name is very confusing, as it doesn't indicate any relationship with the stacktrace display functionality. I also have issue with the term "ignored", as I don't think it reflects what we are really doing here.

[bbatsov]

Perhaps just name this cider-clojure-compilation-error-phases or something like this? I doubt anyone would be changing this one much. As noted by you:

A commonly desirable thing would be that one is presented detailed error reports on application-level exceptions. Compile-time exceptions would not deserve them, by default.

[bbatsov]

Given there's just one UI, I'm guessing you can simplify the wording here. :-)

[bbatsov]

You also need to update the "dealing with errors" docs.

[vemv]

Thanks for the review!

I've amended the last commit applying all feedback.

[vemv]

Amended again

The only change:

In the docs I call defcustom "configuration option, as I think it's more newcomer friendly.

[bbatsov]

Thanks!