Skip to content

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented Feb 21, 2019

Use Case

  • Start figwheel via lein figwheel and have it configured to start an nrepl
  • Connect to nrepl via C-c M-c
  • Start a sibling cljs repl of figwheel-running type, to get into a figwheel-connected browser

Right now, this has to be done with a custom init form, which is annoying


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • All code passes the linter (make lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

## Use Case
- Start figwheel via `lein figwheel` and have it configured to start an nrepl
- Connect to nrepl via `C-c M-c`
- Start a sibling cljs repl of `figwheel-sidecar` type, to get into a figwheel-connected browser

Right now, this has to be done with a custom init form, which is annoying
@bbatsov
Copy link
Member

bbatsov commented Feb 21, 2019

So, that’s the same as what we have right now, but with the difference it doesn’t start figwheel, right? Seems to me the naming is a bit confusing.

@bendlas
Copy link
Contributor Author

bendlas commented Feb 21, 2019

Historically, the -sidecar moniker has been associated with starting figwheel in your process and dropping down to it via cljs-repl, for me.

I agree that there may be better names for it. What about figwheel-piggieback or figwheel-running?

@bendlas bendlas changed the title support figwheel-sidecar sibling cljs repl support figwheel-running sibling cljs repl Feb 21, 2019
@bbatsov
Copy link
Member

bbatsov commented Feb 23, 2019

Or maybe figwheel-connect? I’ll have to think about this a bit. @cichli Any thoughts?

@bendlas bendlas changed the title support figwheel-running sibling cljs repl support figwheel-connected sibling cljs repl Feb 24, 2019
@bendlas
Copy link
Contributor Author

bendlas commented Feb 24, 2019

figwheel-connected implies the precondition of an active nrepl connection. I think I'll go with suggesting that.

@cichli cichli merged commit b5fba37 into clojure-emacs:master Feb 25, 2019
@cichli
Copy link
Member

cichli commented Feb 25, 2019

Thanks for this! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants