Skip to content

Conversation

@jdetter
Copy link
Collaborator

@jdetter jdetter commented Mar 1, 2024

This reverts commit 726080d.

Description of Changes

Please describe your change, mention any related tickets, and so on here.

  • This broke bitcraft with this error:
2024-03-01T19:57:19.479142Z DEBUG crates\client-api\src\routes\subscribe.rs:134: New client connected from unknown ip
thread 'tokio-runtime-worker' panicked at crates\vm\src\expr.rs:827:13:
not yet implemented: Need to implement `NotEq`
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'tokio-runtime-worker' panicked at C:\Users\Boppy\clockworklabs\SpacetimeDB\crates\core\src\client\client_connection.rs:171:14:
called `Result::unwrap()` on an `Err` value: JoinError::Panic(Id(12680), ...)

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

None

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

`

…dexes (and improve the `query!` macro) (#694)"

This reverts commit 726080d.
@jdetter jdetter enabled auto-merge March 1, 2024 20:16
@jdetter jdetter added this pull request to the merge queue Mar 1, 2024
Merged via the queue into master with commit 8e5ce79 Mar 1, 2024
Centril added a commit that referenced this pull request Mar 4, 2024
…olumn indexes (and improve the `query!` macro) (#694)" (#914)"

This reverts commit 8e5ce79.
Centril added a commit that referenced this pull request Mar 5, 2024
…olumn indexes (and improve the `query!` macro) (#694)" (#914)"

This reverts commit 8e5ce79.
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2024
* Revert "Revert "Adding an index selector that take in account multi-column indexes (and improve the `query!` macro) (#694)" (#914)"

This reverts commit 8e5ce79.

* drive-by: refactor impl From<IndexScan> for ColumnOp

* reactor IndexScan bounds structure

* remove temp allocation in extract_fields

* skip index scan for NotEq

* drive-by: simplify Select

* clarify unreachable!(...) for NotEq

Signed-off-by: Mazdak Farrokhzad <[email protected]>

* address Joshua's review + refactor compiler tests

---------

Signed-off-by: Mazdak Farrokhzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants