Skip to content

Revert "Run initial subscriptions evals on rayon" #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2024
Merged

Revert "Run initial subscriptions evals on rayon" #894

merged 1 commit into from
Feb 27, 2024
+11 −30

Conversation

@cloutiertyler
Copy link
Contributor

@cloutiertyler cloutiertyler commented Feb 27, 2024

Reverts #888 due to a deadlocking issue with multiple clients connected.

@jdetter
Copy link
Collaborator

jdetter commented Feb 27, 2024 •
edited
Loading

deadlock symptoms:

  • If you run a single client it will run just fine (subscription queries, sql command, etc.)
  • If you run the bots against PR 888 then it will deadlock very quickly, no subscription data or anything can come back from SpacetimeDB after that point.
  • Restarting the server resolves the issue temporarily until you connect multiple clients again

jdetter
jdetter approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloutiertyler cloutiertyler added this pull request to the merge queue Feb 27, 2024
Merged via the queue into master with commit 488d135 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdetter jdetter jdetter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cloutiertyler @jdetter