Skip to content

Conversation

@jdetter
Copy link
Collaborator

@jdetter jdetter commented Feb 16, 2024

Description of Changes

Dylan got understandably confused by this because the subcommands were just very poorly ordered. I've reordered them alphabetically (discord thread)

New help message:

boppy@boppy-macbook SpacetimeDB % cargo run -- identity --help
    Finished dev [unoptimized + debuginfo] target(s) in 0.18s
     Running `target/debug/spacetime identity --help`
Manage identities stored by the command line tool

Usage: spacetime identity
       spacetime identity <COMMAND>

Commands:
  find          Find an identity for an email
  import        Import an existing identity into your spacetime config
  init-default  Initialize a new default identity if it is missing from a server's config
  list          List saved identities which apply to a server
  new           Creates a new identity
  recover       Recover an existing identity and import it into your local config
  remove        Removes a saved identity from your spacetime config
  token         Print the token for an identity
  set-default   Set the default identity for a server
  set-email     Associates an email address with an identity
  set-name      Set the name of an identity or rename an existing identity nickname
  help          Print this message or the help of the given subcommand(s)

Options:
  -h, --help  Print help

API and ABI breaking changes

No; CLI-only changes.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

1

@jdetter jdetter requested a review from bfops February 16, 2024 00:00
@jdetter jdetter enabled auto-merge February 16, 2024 00:12
@bfops bfops added release-any To be landed in any release window CLI only This change only affects the CLI behavior labels Feb 16, 2024
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

I didn't go through with a fine-toothed comb but the output looks right and nothing's obviously wrong 👍

@jdetter jdetter added this pull request to the merge queue Feb 16, 2024
Merged via the queue into master with commit 04d4771 Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLI only This change only affects the CLI behavior release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants