perf(subscriptions): Add metric counter for subscribe calls #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
added a commit
that referenced
this pull request
Feb 13, 2024
commit 8adad4c Author: John Detter <[email protected]> Date: Tue Feb 13 11:29:27 2024 -0600 Verify that the upgrade-version tool still works for every PR (#825) * Update upgrade-version tool * Verify that version upgrade still works for every PR * Add git diff to the end of CI --------- Co-authored-by: Noa <[email protected]> Co-authored-by: John Detter <[email protected]> Co-authored-by: Zeke Foppa <[email protected]> commit 0260b09 Author: joshua-spacetime <[email protected]> Date: Tue Feb 13 08:23:40 2024 -0800 test(829): Benchmark incremental update for table subscription (#830) Closes #829. commit def2cae Author: joshua-spacetime <[email protected]> Date: Tue Feb 13 08:21:47 2024 -0800 chore(836): Remove tracing instrumentation from database iterators (#837) Closes #836. The tracing library does not fully remove all instrumentation at compile time. And since tracing is not zero cost, it must be removed from the hot path of query execution. commit a32ef34 Author: Noa <[email protected]> Date: Tue Feb 13 09:16:09 2024 -0600 Update upgrade-version tool (#826) * Update upgrade-version tool * Small cludge --------- Co-authored-by: John Detter <[email protected]> commit d4bfb9a Author: Phoebe Goldman <[email protected]> Date: Tue Feb 13 02:56:33 2024 -0500 `ScanIterByColRange`: Avoid unnecessary `ProductValue` allocations (#804) Prior to this commit, `ScanIterByColRange::next` called `RowRef::to_product_value` and then `ProductValue::project_not_empty` on every row in the table to get a key, which it compared to the sought range. This always allocated at least a `ProductValue`, even when seeking a range of primitive type like `u64`. It also unnecessarily deserialized (and potentially allocated) columns not relevant to the search for rows which did not match the range. With this commit, we call `RowRef::project_not_empty` directly. When the sought range is a single column, this avoids allocating a `ProductValue`. Even when seeking a multi-column range, this avoids deserializing unrelated columns of non-matching rows. Non-indexed `IterByColEq` is always going to be slow, so this probably doesn't matter, but it's a trivial change. commit faf8766 Author: Tyler Cloutier <[email protected]> Date: Mon Feb 12 13:42:29 2024 -0800 This fixes replaying of the transaction log to no longer check constraints (#806) * This fixes replaying of the transaction log to no longer check constraints * Fixed based on Phoebe and Kim's comments * Cargo fmt * Cargo fmt * This fixes index updating for replaying deletes --------- Signed-off-by: Tyler Cloutier <[email protected]> commit 295ae3d Author: Noa <[email protected]> Date: Mon Feb 12 14:45:55 2024 -0600 Fix benchmarks (#819) commit 45ae7f7 Author: joshua-spacetime <[email protected]> Date: Mon Feb 12 11:57:56 2024 -0800 chore(datastore): Remove debug instrumentation (#812) commit 7491835 Author: Noa <[email protected]> Date: Mon Feb 12 12:28:42 2024 -0600 ResultInspectExt is obsolete (#818) commit 2de5bf0 Author: joshua-spacetime <[email protected]> Date: Mon Feb 12 10:13:36 2024 -0800 perf(subscriptions): Add metric counter for subscribe calls (#817) commit 4b41998 Author: joshua-spacetime <[email protected]> Date: Fri Feb 9 17:49:15 2024 -0800 test: Add performance benchmark for incremental join query (#795) commit b4f75d2 Author: Noa <[email protected]> Date: Fri Feb 9 13:40:03 2024 -0600 Bump Rust to 1.76.0 (#811) * Bump Rust to 1.76.0 * Fix new clippy lints * Use rust-toolchain in smoketests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Please describe your change, mention any related tickets, and so on here.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.