Skip to content

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Feb 9, 2024

Description of Changes

Allow users to run spacetime publish even if rustup is not present on their system. Typically we use it to install the wasm32-unknown-unknown target.

Addresses #799

API and ABI breaking changes

These are CLI-only changes that don't affect our ABI.

Expected complexity level and risk

1

@bfops
Copy link
Collaborator Author

bfops commented Feb 9, 2024

Fixes #799

@bfops bfops linked an issue Feb 9, 2024 that may be closed by this pull request
@bfops bfops added the CLI only This change only affects the CLI behavior label Feb 9, 2024
@bfops bfops requested a review from jdetter February 13, 2024 19:33
@bfops bfops marked this pull request as ready for review February 13, 2024 19:33
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but looks good to me 👍

@bfops bfops enabled auto-merge February 13, 2024 19:40
@bfops bfops added this pull request to the merge queue Feb 13, 2024
Merged via the queue into master with commit 98fa086 Feb 13, 2024
@bfops
Copy link
Collaborator Author

bfops commented Feb 13, 2024

Oops I forgot to include this, but my testing was:

$ mv ~/.cargo/bin/rustup{,-backup}
$ cd $WORK/my_test_module
$ cargo run publish -c -S publish-test
Warning: Failed to install wasm32-unknown-unknown target: No such file or directory (os error 2). Is `rustup` installed?
    Finished release [optimized] target(s) in 0.05s
Optimising module with wasm-opt...
Could not find wasm-opt to optimise the module.
...

and then afterward to restore rustup:

$ mv ~/.cargo/bin/rustup{-backup,}

@bfops bfops deleted the bfops/fix-799-rustup-issue branch September 5, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLI only This change only affects the CLI behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rustup not found causes publish to fail

3 participants