Skip to content

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Feb 6, 2024

Description of Changes

Exposes MutTxId more than crate-local, which was causing SpacetimeDBPrivate to fail.

API and ABI breaking changes

This is an unbreaking change 🙃

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

@bfops bfops requested a review from cloutiertyler February 6, 2024 23:49
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloutiertyler cloutiertyler added this pull request to the merge queue Feb 7, 2024
Merged via the queue into master with commit bda431c Feb 7, 2024
@bfops bfops deleted the bfops/fix-private branch September 5, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants