Skip to content

Conversation

@drogus
Copy link
Collaborator

@drogus drogus commented Jan 25, 2024

Description of Changes

This PR adds a workflow to tag a docker image linked to the release as latest

Expected complexity level and risk

Low, just a workflow change

@kurtismullins
Copy link
Contributor

@drogus -- Looks great from simply reading it but it will be impractical to test until our next release.

We should confirm with @cloutiertyler and @jdetter that we want to auto-tag spacetimedb:latest because I vaguely remember someone mentioning they want it to be a manual step. I could be wrong!

@drogus
Copy link
Collaborator Author

drogus commented Jan 25, 2024

Looks great from simply reading it but it will be impractical to test until our next release.

Yeah, that's the biggest problem I think 😅 fwiw I've tested it on a test repo and it worked correctly - the only thing that I chnaged bringing it back here is the docker image name

We should confirm with @cloutiertyler and @jdetter that we want to auto-tag spacetimedb:latest because I vaguely remember someone mentioning they want it to be a manual step. I could be wrong!

👍

@bfops bfops added the no runtime change This change does not affect the final binaries label Feb 8, 2024
Copy link
Contributor

@kurtismullins kurtismullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the verbal approval from John that this is the release behavior we want. Ship it!

@drogus drogus added this pull request to the merge queue Feb 14, 2024
Merged via the queue into master with commit 531ca34 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no runtime change This change does not affect the final binaries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants