Skip to content

Conversation

@drogus
Copy link
Collaborator

@drogus drogus commented Jan 24, 2024

Description of Changes

When building a release for a tag we have to build a multi arch image ourselves. So far we tagged it with a tag <short-sha>-full. This is nice to keep the history of all the tagged commits, but it's not very usable as usually we just want the latest build for a given tag. This commit introduces tagging the build with a git tag

Expected complexity level and risk

Very low, only a CI change

When building a release for a tag we have to build a multi arch image
ourselves. So far we tagged it with a tag `<short-sha>-full`. This is
nice to keep the history of all the tagged commits, but it's not very
usable as usually we just want the latest build for a given tag. This
commit introduces tagging the build with a git tag
@drogus drogus force-pushed the drogus/proper-tag-for-multi-arch-builds branch from ef7b6d9 to 2975cef Compare January 24, 2024 16:09
@bfops bfops added the no runtime change This change does not affect the final binaries label Feb 8, 2024
@bfops bfops added the release-any To be landed in any release window label Feb 15, 2024
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, this seems great to me!

@drogus drogus added this pull request to the merge queue Feb 16, 2024
Merged via the queue into master with commit f9a3622 Feb 16, 2024
@drogus drogus deleted the drogus/proper-tag-for-multi-arch-builds branch February 16, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no runtime change This change does not affect the final binaries release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants