Update to axum 0.7 #697
Merged
Update to axum 0.7 #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
noa/axum-07
branch
from
4b8566b to
3ec5085
Compare
coolreader18
force-pushed
the
noa/axum-07
branch
from
3ec5085 to
b7677fd
Compare
|
Code-wise the PR looks fine, but what is a "2" risk? Does this need special testing? |
|
No, not really, I'm confident that there's no issues with this. I just figured it's a core dependency and Tyler said that he's hesitant about updating stuff cause it can introduce bugs, but really these updates should be more stable so this should probably be more of a 1. |
mamcx
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Had this on the backburner for a bit, whoops. This brings us to depending on Hyper 1.0.
Hyper 0.14 is still in the dependency tree, but once reqwest updates we'll be
fully moved over.
Expected complexity level and risk
2