Delete Files Flag for Generate Command #693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
changed the title
gefjon
reviewed
Dec 22, 2023
Comment on lines
159
to
162
| println!("Are you sure you want to delete these files? [y/N]"); | ||
| let mut input = String::new(); | ||
| std::io::stdin().read_line(&mut input)?; | ||
| if input.trim().to_lowercase() == "y" || input.trim().to_lowercase() == "yes" { |
Contributor
There was a problem hiding this comment.
I'd like to see a --force flag or similar which skips this check, so that generate --delete-files --force can be called in scripts.
Collaborator
Author
There was a problem hiding this comment.
I'd like to see a
--forceflag or similar which skips this check, so thatgenerate --delete-files --forcecan be called in scripts.
Added 👍
gefjon
approved these changes
Dec 22, 2023
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
Suggestions for phrasing in flag help messages. Code looks good; is clear to me.
Co-authored-by: Phoebe Goldman <[email protected]> Signed-off-by: John Detter <[email protected]>
Co-authored-by: Phoebe Goldman <[email protected]> Signed-off-by: John Detter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Please describe your change, mention any related tickets, and so on here.
--delete-filesto thespacetime generatecommand which, when supplied, shows the user which files were not generated by us and prompts them if they would like to delete the files. We also check to see if the file starts with our auto-gen tag so that we only prompt the user to delete files that were created by us. This means they can add in their own files and we won't delete them.When running with the new flag we get something like this:
If you enter y or yes to this prompt it will remove the files for you. You can add
--forceonto the end as well if you would like to execute the removal of the files without a prompt.API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
0
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.