Skip to content

Conversation

@jdetter
Copy link
Collaborator

@jdetter jdetter commented Dec 21, 2023

Description of Changes

Please describe your change, mention any related tickets, and so on here.

  • We've gotten feedback, both internally from the BitCraft team and externally, that we should be printing this information when publshing.

New example output:

boppy@boppy-macbook my_rust_module % spacetime publish
info: component 'rust-std' for target 'wasm32-unknown-unknown' is up to date
checking crate with spacetimedb's clippy configuration
    Checking spacetime-module v0.1.0 (/Users/boppy/clockwork/my_rust_module)
    Finished release [optimized] target(s) in 0.16s
    Finished release [optimized] target(s) in 0.08s
Optimising module with wasm-opt...
Uploading to local => http://127.0.0.1:3000
Created new database with address: fc67c3981db589cafc29bfbb94a5c181
...
boppy@boppy-macbook my_rust_module % spacetime publish -s testnet
info: component 'rust-std' for target 'wasm32-unknown-unknown' is up to date
checking crate with spacetimedb's clippy configuration
    Checking spacetime-module v0.1.0 (/Users/boppy/clockwork/my_rust_module)
    Finished release [optimized] target(s) in 0.23s
    Finished release [optimized] target(s) in 0.09s
Optimising module with wasm-opt...
Uploading to testnet => https://testnet.spacetimedb.com
Created new database with address: 6150300e3bfbc9aab5cf03c8b0de4321

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

  • None

Expected complexity level and risk

0

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

@jdetter jdetter requested review from Centril and gefjon December 21, 2023 11:05
@jdetter jdetter enabled auto-merge December 21, 2023 11:07
@jdetter jdetter added this pull request to the merge queue Dec 21, 2023
Merged via the queue into master with commit cdde960 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants