refactor(compiler): Swap the index and probe sides of an index join #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/refactor/index-join-reorder
branch
from
1a89622 to
6f21b41
Compare
joshua-spacetime
changed the title
Base automatically changed from
joshua/refactor/incremental-evaluation
to
master
December 13, 2023 19:59
joshua-spacetime
force-pushed
the
joshua/refactor/index-join-reorder
branch
from
6f21b41 to
5e0dfeb
Compare
joshua-spacetime
force-pushed
the
joshua/refactor/index-join-reorder
branch
from
ae343dd to
274efed
Compare
Before this change we would swap the index and probe sides if (1) the index side was replaced with a delta table, (2) the probe side had an index defined on the join field, and (3) the index side was the return side. After this change we swap if (1) the index side has been replaced with a delta table, and (2) the probe side has an index defined on the join field. We no longer place restrictions on the rows that are returned.
joshua-spacetime
force-pushed
the
joshua/refactor/index-join-reorder
branch
from
274efed to
1dd0d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Before this change we would swap the index and probe sides if
(1) the index side was replaced with a delta table,
(2) the probe side had an index defined on the join field, and
(3) the index side was the return side.
After this change we swap if
(1) the index side has been replaced with a delta table, and
(2) the probe side has an index defined on the join field.
We no longer place restrictions on the rows that are returned.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.