Fixes for performance drop related to missing index selection #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
force-pushed
the
mamcx/perf-header
branch
from
2e58ed8 to
ffffc85
Compare
cloutiertyler
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR fixes the issues that cause the query optimizations to miss the opportunity to use indexes.
This is caused by several problems introduced in #596:
constraintsinformation was not read correctlyTableDefinformation it generatesConstraints::unset()for all the columns without attributes. This causes the index information to skip them despite having indexes availableAPI and ABI breaking changes
This requires a database wipe
Expected complexity level and risk
1