Skip to content

Conversation

@joshua-spacetime
Copy link
Collaborator

Query optimization will soon need this metric.
Therefore it must be moved out of core and into lib. Eventually we might want to move all metrics into lib.

Description of Changes

Please describe your change, mention any related tickets, and so on here.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

@joshua-spacetime joshua-spacetime force-pushed the joshua/refactor/move-table-size-metric branch from a9ef414 to 7161e6d Compare December 6, 2023 23:21
@joshua-spacetime joshua-spacetime changed the title refactor(623): Move table size metric into lib refactor(metrics): Move table size metric into lib Dec 6, 2023
Query optimization will soon need this metric.
Therefore it must be moved out of core and into lib.
Eventually we might want to move all metrics into lib.
@joshua-spacetime joshua-spacetime force-pushed the joshua/refactor/move-table-size-metric branch from 7161e6d to 89b2864 Compare December 8, 2023 00:46
Copy link
Contributor

@kulakowski kulakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re crate layout, I know @coolreader18 has expressed wanting to move some code around too, between crates. I don't know the best way exactly to set that up, but I think it's about time for us to actually design it out (like, write down that things with X property or needed for Y have to go in Z crate, and the code within it is subject to C constraint because...) and then commit to it within a release cycle.

@joshua-spacetime joshua-spacetime merged commit 09b2d0f into master Dec 8, 2023
@joshua-spacetime joshua-spacetime deleted the joshua/refactor/move-table-size-metric branch December 8, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants