Support arbitrary RHS in C# Query #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReverser
force-pushed
the
csharp-extended-rhs-query
branch
from
4624e7d to
382f4cc
Compare
Unlike Rust, previously this would only accept literal constants. Unlike Rust, this will now accept not only constants and captures, but arbitrary expressions - we can probably do the same in Rust or limit this in the future.
RReverser
force-pushed
the
csharp-extended-rhs-query
branch
from
37fa459 to
8ae0fa1
Compare
kulakowski
approved these changes
Dec 5, 2023
| /// | ||
| /// Sync with: `core::database_logger::Record`. We can't use it | ||
| /// directly because the types are wrong for deserialization. | ||
| /// (Rust!) |
There was a problem hiding this comment.
I don't know what Rust! means here.
There was a problem hiding this comment.
Me neither. This code was just moved around.
| "Hello, Tyrion!", | ||
| "Hello, Cersei!", | ||
| "Hello, World!", | ||
| "Cersei has age 31 >= 30", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Unlike Rust, previously this would only accept literal constants and not field captures.
Unlike Rust, this will now accept not only constants and captures, but arbitrary expressions - we can either do the same in Rust or limit this similarly in the future.
Some of the changes here are just to add queries to primary integration tests too and make checking logs a bit easier, feel free to review on per-commit basis.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
2 - this is using special C# dynamic evaluation API to evaluate non-constant RHS expressions, but tests show it works as expected in practice.
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.