Forbid unsupported syntax in SELECT & improve sql test suite #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y of sql test suite
cloutiertyler
approved these changes
Jun 22, 2023
Centril
reviewed
Jun 22, 2023
Co-authored-by: Mazdak Farrokhzad <[email protected]> Signed-off-by: Mario Montoya <[email protected]>
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
* Forbid unsupported syntax in SELECT (like ORDER BY) & improve accuracy of sql test suite * Update crates/sqltest/src/main.rs Co-authored-by: Mazdak Farrokhzad <[email protected]> Signed-off-by: Mario Montoya <[email protected]> --------- Signed-off-by: Mario Montoya <[email protected]> Co-authored-by: Mazdak Farrokhzad <[email protected]>
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
* Forbid unsupported syntax in SELECT (like ORDER BY) & improve accuracy of sql test suite * Update crates/sqltest/src/main.rs Co-authored-by: Mazdak Farrokhzad <[email protected]> Signed-off-by: Mario Montoya <[email protected]> --------- Signed-off-by: Mario Montoya <[email protected]> Co-authored-by: Mazdak Farrokhzad <[email protected]>
bfops
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Add some client tests This adds tests for the client and the ability to supply a test adapter. I also tried to mock WS, but for some reason it didn't work and I figured out making our own adapter is simple enough.
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
* Fix compilation issue with master * Initial push for SATS (still WIP) * Small build fix * Small update * Updates from meeting with Tyler * Fixed issues with LayoutExplicit and added some missing functions * AlgebraicValue cleanup * Copied changes from BitCraftMini * Removed TypeDef --------- Co-authored-by: Clockwork Labs <[email protected]> Co-authored-by: Tyler Cloutier <[email protected]> Co-authored-by: John Detter <[email protected]>
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Add some client tests This adds tests for the client and the ability to supply a test adapter. I also tried to mock WS, but for some reason it didn't work and I figured out making our own adapter is simple enough.
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Fix compilation issue with master * Initial push for SATS (still WIP) * Small build fix * Small update * Updates from meeting with Tyler * Fixed issues with LayoutExplicit and added some missing functions * AlgebraicValue cleanup * Copied changes from BitCraftMini * Removed TypeDef --------- Co-authored-by: Clockwork Labs <[email protected]> Co-authored-by: Tyler Cloutier <[email protected]> Co-authored-by: John Detter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Forbid unsupported syntax in
SELECT(likeORDER BY,LIMIT, etc) & improve the accuracy of SQL test suite reporting how many tests were skipped (because for example, they are forGRANTcommands that have no support onSQLiteorSpaceTimeDB.API
If the API is breaking, please state below what will break