Move optimizations from sql to vm #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
joshua-spacetime
left a comment
joshua-spacetime
left a comment
There was a problem hiding this comment.
Nice! Is it possible to add a test for query! now?
Contributor
Author
In this PR or make another? |
Collaborator
|
@mamcx is it possible to include it in this PR? Unless there are more changes needed to get |
joshua-spacetime
approved these changes
Oct 30, 2023
Collaborator
joshua-spacetime
left a comment
joshua-spacetime
left a comment
There was a problem hiding this comment.
LGTM! I'm not sure where a test for query! would go, so it's probably best to figure that out in a follow up patch.
mamcx
force-pushed
the
mamcx/query-opt-move
branch
from
7c1b2e4 to
3acbea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
To improve the performance of the
querymacro, move the query optimization from thesqlcompilation into thevmexecution engine instead.API and ABI
If the API is breaking, please state below what will break
Expected complexity level and risk
1