Use gh actions for benchmarks please #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
noa/gh-actions-benchmarks-please
branch
from
d7e1db5 to
9ad7b5d
Compare
coolreader18
force-pushed
the
noa/gh-actions-benchmarks-please
branch
from
9ad7b5d to
36401e5
Compare
kurtismullins
approved these changes
Oct 26, 2023
.github/workflows/benchmarks.yml
Outdated
| - name: Check membership | ||
| if: ${{ env.PR_NUMBER }} | ||
| run: | ||
| if [[ $(gh api /orgs/{owner}/members --jq 'any(.login == env.GITHUB_ACTOR)') != true ]]; then |
There was a problem hiding this comment.
Nice!
In the future, we may want to look into CODEOWNERS but this is great and easy to follow.
|
test |
|
well, it will indeed create a workflow run for every single comment made in the repository, even though it gets filtered by the if condition. but not much that can be done about that, I don't think |
jdetter
pushed a commit
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
See the successful workflow run and the comment it posted