lib: Don't panic in RelValueRef::get #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no guarantee that a named field is in the supplied table header, nor that it is in the row. Panicking at this location can be disastrous, while all call sites are inside Result already. So, return Result.
Centril
approved these changes
Oct 19, 2023
|
|
||
| pub fn get(&self, col: &'a FieldExpr, header: &'a Header) -> &'a AlgebraicValue { | ||
| match col { | ||
| pub fn get(&self, col: &'a FieldExpr, header: &'a Header) -> Result<&'a AlgebraicValue, RelationError> { |
There was a problem hiding this comment.
@mamcx would know the details here more than I would. Ideally the compiler would ensure we never panic here, but this seems fine given that the callers return Result anyway.
jdetter
pushed a commit
that referenced
this pull request
Oct 31, 2023
There is no guarantee that a named field is in the supplied table header, nor that it is in the row. Panicking at this location can be disastrous, while all call sites are inside Result already. So, return Result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
There is no guarantee that a named field is in the supplied table header, nor that it is in the row. Panicking at this location can be disastrous, while all call sites are inside Result already. So, return Result.
API and ABI
If the API is breaking, please state below what will break
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
1