Avoid relying on global CLI in tests #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches tests from invoking a spacetimedb CLI found on PATH to always using up-to-date version by depending on the CLI crate as a library.
RReverser
force-pushed
the
invoke-cli-via-api
branch
from
ded1a11 to
d910362
Compare
gefjon
reviewed
Sep 13, 2023
Project configs can't ever be programmatically updated; attempting to init a new identity in one will fail. Signed-off-by: Phoebe Goldman <[email protected]>
gefjon
approved these changes
Sep 14, 2023
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
## Description of Changes Addresses clockworklabs/SpacetimeDBPrivate#1585 There was an issue with row deduplication when a TransactionUpdate of the form: ``` + k1: v1 - k1: v1 - k1: v1 + k1: v2 ``` appeared, where `k1` is the primary key of a row and `v1`, `v2` are the full values of that row. The old manner of processing updates would see this as a no-op. I've updated the logic to handle this case correctly, at the cost of an extra equality comparison per row in an update. (Actually it's slightly cheaper than this, it skips the equality comparison if there is only row with a particular primary key in an update. This may help speed up processing of large updates e.g. chunk data in BitCraft.) ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs ## Testsuite SpacetimeDB branch name: master ## Testing - [x] Added a failing test, then fixed it
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
## Description of Changes Addresses clockworklabs/SpacetimeDBPrivate#1585 There was an issue with row deduplication when a TransactionUpdate of the form: ``` + k1: v1 - k1: v1 - k1: v1 + k1: v2 ``` appeared, where `k1` is the primary key of a row and `v1`, `v2` are the full values of that row. The old manner of processing updates would see this as a no-op. I've updated the logic to handle this case correctly, at the cost of an extra equality comparison per row in an update. (Actually it's slightly cheaper than this, it skips the equality comparison if there is only row with a particular primary key in an update. This may help speed up processing of large updates e.g. chunk data in BitCraft.) ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs ## Testsuite SpacetimeDB branch name: master ## Testing - [x] Added a failing test, then fixed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This switches tests from invoking a spacetimedb CLI found on PATH to always using up-to-date version by depending on the CLI crate as a library.
API and ABI
If the API is breaking, please state below what will break