Refactor with #[derive(derive_more::From)]
#281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/derive-more
branch
from
429516d to
a51c631
Compare
joshua-spacetime
approved these changes
Sep 12, 2023
Comment on lines
+373
to
381
| #[from] | ||
| Value(AlgebraicValue), |
Collaborator
There was a problem hiding this comment.
Does this mean From is only implemented for this variant and not the others?
Contributor
Author
There was a problem hiding this comment.
Yep, exactly; you can also use #[from(ignore)] when you want most variants save for one or so.
Centril
force-pushed
the
centril/derive-more
branch
from
a51c631 to
5127ec7
Compare
Centril
force-pushed
the
centril/derive-more
branch
from
5127ec7 to
a3ad975
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Refactors some code with
#[derive(derive_more::From)].API and ABI
If the API is breaking, please state below what will break