perf: read DataKey instead of recomputing it in subscriptions #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/259/data-key-optimization
branch
2 times, most recently
from
e835bb2 to
684258b
Compare
Centril
reviewed
Sep 12, 2023
| impl DataRef { | ||
| fn new(data: ProductValue) -> Self { | ||
| Self { data } | ||
| fn new(id: DataKey, data: ProductValue) -> Self { |
There was a problem hiding this comment.
Should this take RowId instead?
Suggested change
| fn new(id: DataKey, data: ProductValue) -> Self { | |
| fn new(id: RowId, data: ProductValue) -> Self { |
There was a problem hiding this comment.
Do we gain anything from the extra indirection?
There was a problem hiding this comment.
From what I could tell, all calls to this function essentially does row_id.0, so I figured this would be slightly more "strongly typed".
Centril
reviewed
Sep 12, 2023
joshua-spacetime
force-pushed
the
joshua/259/data-key-optimization
branch
from
5629348 to
6a9c13d
Compare
Centril
approved these changes
Sep 12, 2023
) Fixes #259 (1) Updates MemTable to use RelValue instead of ProductValue (2) Adds a DataKey member to DataRef and RelValue (3) Subscriptions compute DataKey only when not present on row
joshua-spacetime
force-pushed
the
joshua/259/data-key-optimization
branch
from
e9c4a59 to
dba0b96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Re-introduces the changes of #268 with a fix for improperly decoding the DataKey.
The original patch tried to encode a byte slice in
to_mem_tableusingDataKey::from_datarather thanDataKey::decode. The former assumes the byte slice is data only, the latter assumes it is a proper DataKey encoding.Tested against #258
API and ABI
If the API is breaking, please state below what will break