perf: remove table headers from rows in query engine #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/270/remove-table-headers-from-rows
branch
from
3c4ef3c to
9490776
Compare
|
benchmarks please |
2 similar comments
|
benchmarks please |
|
benchmarks please |
Benchmark for 9490776Click to view benchmark
|
Centril
reviewed
Sep 11, 2023
joshua-spacetime
force-pushed
the
joshua/270/remove-table-headers-from-rows
branch
3 times, most recently
from
6ee8524 to
bd20b5e
Compare
joshua-spacetime
force-pushed
the
joshua/270/remove-table-headers-from-rows
branch
from
bd20b5e to
413ee24
Compare
Centril
approved these changes
Sep 13, 2023
joshua-spacetime
deleted the
joshua/270/remove-table-headers-from-rows
branch
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
Adds an additional test of the `GenericEqualityComparer` function for `Integer`, `String`, `Byte Array`, `Identity`, `User` and `TaggedEnum` type comparisons. This PR resolves additional checks as reported in by [Issue 230](clockworklabs/com.clockworklabs.spacetimedbsdk#230) that where not-yet covered elsewhere. ## API - [ ] This is an API breaking change to the SDK ## Requires SpacetimeDB PRs No other PR are needed for this to work. ## Testsuite SpacetimeDB branch name: master ## Testing - [X] Locally ran `dotnet test` against the `tests.csproj` project and it passed all tests
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
Adds an additional test of the `GenericEqualityComparer` function for `Integer`, `String`, `Byte Array`, `Identity`, `User` and `TaggedEnum` type comparisons. This PR resolves additional checks as reported in by [Issue 230](clockworklabs/com.clockworklabs.spacetimedbsdk#230) that where not-yet covered elsewhere. ## API - [ ] This is an API breaking change to the SDK ## Requires SpacetimeDB PRs No other PR are needed for this to work. ## Testsuite SpacetimeDB branch name: master ## Testing - [X] Locally ran `dotnet test` against the `tests.csproj` project and it passed all tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #270
Description of Changes
Relational iterators return RelValues which for convenience
contained table headers for indexing into the underlying
ProductValues. This patch removes them to improve memory
bandwidth.
API and ABI
If the API is breaking, please state below what will break