Skip to content

Conversation

@SteveGibsonCL
Copy link
Contributor

@SteveGibsonCL SteveGibsonCL commented Aug 23, 2023

Description of Changes

Steve:

  • Fixed json serializer settings getting re-created every reducer call, leading to gradual performance decline
    John:
  • During the review of this PR I figured out that option serialization support in the C# SDK was completely broken, which required some changes here to fix.

API and ABI

  • This is a breaking change to the module ABI
  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI
  • This is a breaking change to the SDK API

If the API is breaking, please state below what will break

Requires this PR in order for the client to work: clockworklabs/com.clockworklabs.spacetimedbsdk#51

@SteveGibsonCL SteveGibsonCL requested a review from jdetter August 23, 2023 20:16
@SteveGibsonCL SteveGibsonCL enabled auto-merge (squash) August 23, 2023 20:17
@jdetter jdetter force-pushed the csharp-json-allocations-fix branch from 184676a to c742588 Compare August 23, 2023 22:03
@SteveGibsonCL SteveGibsonCL merged commit 9dc90bb into master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants