Spacetime identity remove force flag #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
approved these changes
Jun 26, 2023
| std::io::stdout().flush()?; | ||
| std::io::stdin().read_line(&mut input)?; | ||
|
|
||
| if input.trim() != "y" { |
Contributor
There was a problem hiding this comment.
Consider https://crates.io/crates/yn or something like that.
gefjon
reviewed
Jun 26, 2023
| .required_unless_present("identity"), | ||
| ).arg( | ||
| Arg::new("force") | ||
| .long("force") |
Contributor
There was a problem hiding this comment.
Should this have .short("f")? Or whatever the incantation is to allow spacetime identity remove --all -f?
| .action(ArgAction::SetTrue) | ||
| .requires("all") | ||
| .conflicts_with("identity") | ||
| .required_unless_present("identity"), |
Contributor
There was a problem hiding this comment.
Is this correct? I would think we want to allow --all without --force. I guess I'm not super sure on how this argparse library works, but I think that we want all of these invocations to be acceptable:
spacetime identity remove SOME_IDENTITYspacetime identity remove --allspacetime identity remove --all --force
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
Co-authored-by: Boppy <[email protected]>
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
Co-authored-by: Boppy <[email protected]>
bfops
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Add license.text * Fix case on file name --------- Co-authored-by: Derek Brinkmann <[email protected]>
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
Co-authored-by: Derek Brinkmann <[email protected]>
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Add license.text * Fix case on file name --------- Co-authored-by: Derek Brinkmann <[email protected]>
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
Co-authored-by: Derek Brinkmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
spacetime identity removecommand so it can more easily be used in CIAPI
If the API is breaking, please state below what will break