Fix incomplete transaction bug #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutiertyler
approved these changes
Jun 26, 2023
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
* Fix incomplete transaction bug * Clippy
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
* Fix incomplete transaction bug * Clippy
bfops
pushed a commit
that referenced
this pull request
Jul 16, 2025
Remove `protobufjs` from devDependencies
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
* Empty push to trigger a webhook * Update TypeScript docs to 0.8
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
* Add onSubscriptionUpdate callback * Remove unnecesary onTransactionComplete --------- Co-authored-by: Derek Brinkmann <[email protected]>
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
Remove `protobufjs` from devDependencies
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Add onSubscriptionUpdate callback * Remove unnecesary onTransactionComplete --------- Co-authored-by: Derek Brinkmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I wrap the usage of
Txinside thevmlogic so it correctly deals with an error that must roll back.API
If the API is breaking, please state below what will break