Fix/improve incorrect serialization/deserialization of commit messages #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
bfops
pushed a commit
that referenced
this pull request
Jul 16, 2025
bfops
added a commit
that referenced
this pull request
Jul 17, 2025
## Description of Changes This creates a frankenstein monster of a repo that is compatible with both .NET / MSBuild as well as can be consumed as a Unity package. - `.meta` files, Unity manifests and Unity README were copied over from the Unity repo. - `examples` and `tests` folders were renamed to `examples~` and `tests~` correspondingly, as the `~` suffix is the only way to get entire folders ignored by Unity. - MSBuild was configured to change `bin` and `obj` to `bin~` and `obj~` for the same reasons. This doesn't matter for the Git repo, but helpful for local development where you don't want Unity to try and load local DLL artifacts. - NuGet was configured to restore Unity-compatible NuGet DLLs (and delete others) in a local folder and committed to the repo - so, from now on, we can easily update them by modifying `.csproj` and via standard `dotnet restore` / `dotnet build`. After this change, this repo should be compatible with both .NET CLI (e.g. `dotnet test`) as well as consumable from Unity, but due to amount of metadata changes, it needs further testing before we merge repos properly. Fixes #114. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* --------- Co-authored-by: Zeke Foppa <[email protected]>
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
bfops
added a commit
that referenced
this pull request
Aug 7, 2025
## Description of Changes This creates a frankenstein monster of a repo that is compatible with both .NET / MSBuild as well as can be consumed as a Unity package. - `.meta` files, Unity manifests and Unity README were copied over from the Unity repo. - `examples` and `tests` folders were renamed to `examples~` and `tests~` correspondingly, as the `~` suffix is the only way to get entire folders ignored by Unity. - MSBuild was configured to change `bin` and `obj` to `bin~` and `obj~` for the same reasons. This doesn't matter for the Git repo, but helpful for local development where you don't want Unity to try and load local DLL artifacts. - NuGet was configured to restore Unity-compatible NuGet DLLs (and delete others) in a local folder and committed to the repo - so, from now on, we can easily update them by modifying `.csproj` and via standard `dotnet restore` / `dotnet build`. After this change, this repo should be compatible with both .NET CLI (e.g. `dotnet test`) as well as consumable from Unity, but due to amount of metadata changes, it needs further testing before we merge repos properly. Fixes #114. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* --------- Co-authored-by: Zeke Foppa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes the following issues with the serialization of the commit log:
API
If the API is breaking, please state below what will break
This isn't exactly a break in the APIs but it's a change in the serialization/deserialization of the commit log, which means that existing databases will not startup correctly with this change