Skip to content

Conversation

@jdetter
Copy link
Collaborator

@jdetter jdetter commented Apr 22, 2024

Description of Changes

Please describe your change, mention any related tickets, and so on here.

Previous command was:

spacetime identity list <server>

New command is:

spacetime identity list -s <server>

The new command is more consistent with all of the other spacetime CLI commands which take a server argument.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Technically yes, just a CLI change.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

0

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Do spacetime identity list -s <server> or leave -s <server> unset to list identities for the default server.

Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ The hero we need

@bfops bfops added release-any To be landed in any release window CLI only This change only affects the CLI behavior labels Apr 22, 2024
@bfops bfops added this pull request to the merge queue Apr 22, 2024
Merged via the queue into master with commit 06f766f Apr 22, 2024
bfops pushed a commit that referenced this pull request Apr 22, 2024
@bfops bfops added the api-break A PR that makes an API breaking change label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-break A PR that makes an API breaking change CLI only This change only affects the CLI behavior release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants