Skip to content

Conversation

@jdetter
Copy link
Collaborator

@jdetter jdetter commented Apr 19, 2024

Description of Changes

Please describe your change, mention any related tickets, and so on here.

Right now the default log level for the commitlog is debug which is pretty noisy when loading a database from disk:

image

After defaulting it to info its much more reasonable:

image

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

No API/ABI break

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

0 - this is just changing log levels

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Try loading a database before this change, the log is pretty spammy, try with this change and its much better. See screenshots.

@jdetter jdetter requested a review from kim April 19, 2024 07:32
Copy link
Contributor

@kim kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jdetter jdetter added this pull request to the merge queue Apr 19, 2024
Merged via the queue into master with commit c9381af Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants