Skip to content

Conversation

@Centril
Copy link
Contributor

@Centril Centril commented Apr 18, 2024

Description of Changes

  • Defines hash_bsatn to hash an AV encoded as BSATN.
  • Defines eq_bsatn to compare AV encoded BSATN against an AV.

API and ABI breaking changes

None.

Expected complexity level and risk

2, we need to make sure the algorithms are consistent with AVs.

Testing

  • proptests are provided

@Centril Centril changed the base branch from master to centril/weaker-av-hash April 18, 2024 13:40
@Centril Centril requested review from gefjon and kazimuth April 18, 2024 14:44
Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, everything looks clean.

I'm curious, what do the reborrows on the deserializer do? (This may have been discussed before, but if so I missed it.)

@bfops bfops added the release-any To be landed in any release window label Apr 22, 2024
@Centril
Copy link
Contributor Author

Centril commented Apr 23, 2024

I'm curious, what do the reborrows on the deserializer do? (This may have been discussed before, but if so I missed it.)

Basically, they exist to make the borrow checker happy, Deserializer { reader: self.reader } is what they do, so more or less a no-op.

Base automatically changed from centril/weaker-av-hash to master April 24, 2024 12:13
@Centril Centril force-pushed the centril/bsatn-hash-eq branch from 87255f0 to 5ef9bd3 Compare April 24, 2024 22:50
@Centril Centril enabled auto-merge April 24, 2024 22:50
@Centril Centril added this pull request to the merge queue Apr 24, 2024
Merged via the queue into master with commit cb0c09b Apr 24, 2024
@Centril Centril deleted the centril/bsatn-hash-eq branch April 25, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants