cli: Suggest to make new identity the default for server #1109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a server key rotation is suspected, suggest to make the new identity the default. This usually happens during development using an ephemeral instance. If one follows the instructions, the `default_identity` is not set for the existing server, which makes the CLI generate a fresh identity every time. See also: #333
jdetter
reviewed
Apr 19, 2024
| \tspacetime identity remove {identity} | ||
| Generate a new identity with: | ||
| \tspacetime identity new --no-email --server {server}" | ||
| \tspacetime identity new --no-email --server {server} --default" |
There was a problem hiding this comment.
We should fix the UX issue in general, but regardless this is a good change to the warning to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a server key rotation is suspected, suggest to make the new identity the default.
This usually happens during development using an ephemeral instance. If one follows the instructions, the
default_identityis not set for the existing server, which makes the CLI generate a fresh identity every time.See also: #333
Expected complexity level and risk
1
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
spacetime identity new --no-email --server <the server>(without--default)spacetime identity new --no-email --server <the server> --default(as suggested)