core: Don't persist empty transactions #1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a minor bug where completely empty transactions would still be written to the commitlog. The bug is minor because, once we start logging inputs, all transactions will be non-empty. The check is done in relational DB rather than the durability crate, because in principle empty transactions are permissible, and may be used in the future (e.g. to confirm a certain offset).
| log::trace!("append {txdata:?}"); | ||
| // TODO: Should measure queuing time + actual write | ||
| durability.append_tx(txdata); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| // Fix a minor bug where completely empty transactions would still be | |
| // written to the commitlog. The bug is minor because, once we start | |
| // logging inputs, all transactions will be non-empty. | |
| // The check is done in relational DB rather than the durability crate, | |
| // because in principle empty transactions are permissible, and may be used | |
| // in the future (e.g. to confirm a certain offset). |
cloutiertyler
approved these changes
Apr 12, 2024
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
Approving with one suggestion to add the PR comment to the actual code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a minor bug where completely empty transactions would still be
written to the commitlog. The bug is minor because, once we start
logging inputs, all transactions will be non-empty.
The check is done in relational DB rather than the durability crate,
because in principle empty transactions are permissible, and may be used
in the future (e.g. to confirm a certain offset).
Expected complexity level and risk
1
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
modify rows (where previously it was present).