Skip to content

fix: shell detection message always outputed when generating completion #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2023
Merged

fix: shell detection message always outputed when generating completion #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7bc441
fix: shell detection message always outputed when generating completion
Subjective Sep 6, 2023
539696c
Remove shell detection message
Subjective Sep 6, 2023
9b9ca93
Update README
Subjective Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ You may also obtain specific shell configuration using.
leetcode completions fish
```

If no argument is provided, the shell is inferred from the `SHELL` environment variable.

</details>

## Usage
Expand Down
5 changes: 1 addition & 4 deletions src/cmds/completions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,7 @@ fn get_completions_string<G: Generator>(gen: G, cmd: &mut ClapCommand) -> Result
pub fn completion_handler(m: &ArgMatches, cmd: &mut ClapCommand) -> Result<(), Error> {
let shell = *m.get_one::<Shell>("shell").unwrap_or(
// if shell value is not provided try to get from the environment
{
println!("# Since shell arg value is not provided trying to get the default shell from the environment.");
&Shell::from_env().ok_or(Error::MatchError)?
}
&Shell::from_env().ok_or(Error::MatchError)?,
);
let completions = get_completions_string(shell, cmd)?;
println!("{}", completions);
Expand Down