Update mill to 0.12.4 #172
Conversation
nightscape
force-pushed
the
mill-0.12
branch
4 times, most recently
from
595aebf to
6e7e43c
Compare
build.sc
Outdated
| "reconciledRange" -> "verify", | ||
| "cyclical" -> "checkManifest" | ||
| ).filter { | ||
| // The reconciledRange test doesn't work under 0.12 atm |
There was a problem hiding this comment.
So this was due to what I believe is a bug in coursier. I created an issue for it in coursier/coursier#2682 but never got a response about what is actually happening. Maybe this is fixed with the new changes in coursier, but I'd need to dig deeper to better understand if that's the case. Right now you can go ahead and just ignore this and I'll try to look deeper at what's happening.
There was a problem hiding this comment.
I dug a bit deeper and created com-lihaoyi/mill#4165.
| T { | ||
| val env = if(millTestVersion() >= "0.12") | ||
| Map( | ||
| "COURSIER_REPOSITORIES" -> s"central sonatype:releases ivy:file://${T.dest.toString.replaceFirst("testInvocations", "test")}/ivyRepo/local/[organisation]/[module]/[revision]/[type]s/[artifact].[ext]" |
There was a problem hiding this comment.
So is this needed now for 0.12 versions?
There was a problem hiding this comment.
Yes, this was the only way I found to make Mill / Coursier pick up the local dev repo.
In Mill 0.12+ there is a different way to integration-test Mill plugins, with which this hack/workaround would probably go away. But that doesn't work for 0.10 and 0.11, so I guess it's best to live with the workaround until usage of Mill < 0.12 dies out and one can completely switch to the new approach.
nightscape
force-pushed
the
mill-0.12
branch
from
6e7e43c to
9753ee5
Compare
|
@ckipp01 I hope/think I fixed the remaining issues:
Could you approve GitHub Actions to run the tests again? |
|
Ok, tests are looking good. I'll fix the style issues then it should be good to merge. |
nightscape
force-pushed
the
mill-0.12
branch
4 times, most recently
from
f5fc7d3 to
6440c33
Compare
|
I fixed all logged style errors and force-pushed the results. I hope this doesn't happen in the GitHub Actions. |
nightscape
force-pushed
the
mill-0.12
branch
from
6440c33 to
3b0526f
Compare
nightscape
force-pushed
the
mill-0.12
branch
from
3b0526f to
d0f6961
Compare
|
@ckipp01 all green, ready to merge from my side 👍 |
ckipp01
left a comment
ckipp01
left a comment
There was a problem hiding this comment.
Thanks a lot for your work on this @nightscape. LGTM
|
@ckipp01 looks like the release process has 0.12 problems...
|
|
Yes, I see that. I think maybe for now we should just use 0.11.x to publish, then try to update mill-ci-release to work with 0.12.x. |
2 participants
@ckipp01 this one was a little bit of a PITA, so it would be nice to get it merged soonish 😉
It adds compatibility with Mill 0.12, but still retains compatibility with previous versions.
Only the
reconcileRangestest doesn't work, not sure what changed there...