Fix non-total predicates in tail position in cptypes #985
+53
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid moving predicates from tail position when they may raise an error, in spite the result in known in case of a success.
In particular, in
it's clear that it will be #t if not an error, but it's not possible to replace it with
(begin (exact? x) #t)in tail position.I added a check for
(debug-level), but I'm not sure it's correct.I'm sure this is a bug, but I don't have an example where I can see an incorrect result. It's probably a combination of
with-handlersto inspect the continuation marks, but I'm not sure.