Improve RemoteName parser #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Sep 5, 2022
| @@ -0,0 +1,13 @@ | |||
| grammar Reference; | |||
There was a problem hiding this comment.
What the origin of this grammar? You compiled it from a spec? Would be nice to have a link here.
There was a problem hiding this comment.
No, it's a port of the old grammar that Tart used, but more (1) readable/editable and (2) strict w.r.t. potential path traversal (see d8a71ec).
I've realized that it's not worth porting the "official spec" because Tart is not a registry, so it's parser could be more relaxed, however, it needs to safely handle potential path traversal (e.g. with ../../..).
fkorotkov
approved these changes
Sep 6, 2022
edigaryev
added a commit
that referenced
this pull request
Sep 6, 2022
edigaryev
added a commit
that referenced
this pull request
Oct 11, 2022
* Improve RemoteName parser * Remove Parsing import * Permit namespace components to contain separators, but no more than one * Add testNoPathTraversal
edigaryev
added a commit
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #35.