Skip to content

Conversation

@yujiyokoo
Copy link
Contributor

@yujiyokoo yujiyokoo commented Oct 8, 2024

The main part of this PR is in CipherStash-Getting-Started.ipynb but I would not recommend reviewing much by looking at the file content. Instead, use of jupyter notebook is recommended.

You'd need:

  • Python 3
  • Jupyter notebook
  • Docker
  • Docker compose
  • CipherStash account
  • CipherStash CLI

Run it in the jupyter/ directory with jupyter notebook, select CipherStash-Getting-Started.ipynb and follow the instructions.

This adds a Jupyter Notebook for Python 3 + psycopg2.

The sql files and dataset.yml are just copy-paste and some edit from the Ruby e2e-mlp.

docker-compose.yml starts up PostgreSQL and Proxy.

TODO:

  • Add SQLAlchemy support

@yujiyokoo yujiyokoo marked this pull request as ready for review October 21, 2024 22:07
Copy link
Contributor

@auxesis auxesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @yujiyokoo!

I have run through this with @yujiyokoo, and the bones of it are working.

We have several other small improvements we want to make, but we're going to tackle them in future smaller PRs.

Only thing we need to change before merging is to put python/ under the languages/ directory.

@@ -0,0 +1,819 @@
DROP CAST IF EXISTS (text AS ore_64_8_v1_term);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The eql sql has been moved to this repo, so you can point to the release folder instead of having to copy this over.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fimac 🙏 I've added it to this issue.

@yujiyokoo yujiyokoo force-pushed the cip-796-test-stack-python-psycopg2-jupyter-notebook-greenfields branch from f1b8181 to 2f8e853 Compare October 22, 2024 06:50
@yujiyokoo yujiyokoo merged commit 38c3cec into main Oct 22, 2024
@yujiyokoo yujiyokoo deleted the cip-796-test-stack-python-psycopg2-jupyter-notebook-greenfields branch October 22, 2024 06:50
tobyhede pushed a commit that referenced this pull request Oct 27, 2025
…opg2-jupyter-notebook-greenfields

Add Python 3 + psycopg2 + Jupyter Notebook example
tobyhede added a commit that referenced this pull request Oct 30, 2025
Replace terse "9 assertions" comments with descriptive format:
"9 assertions: reflexive, transitive, and antisymmetric comparison properties"

This makes it clear what the assertion group is testing, improving
code readability and maintainability.

Addresses FINAL_CODE_REVIEW.md recommendation #7 (P4).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants