Skip to content

[ENH] Make a DirtyMarker have a backfill bit. #5850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+301 −39
Open

[ENH] Make a DirtyMarker have a backfill bit. #5850

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
449c80d
[ENH] Make a DirtyMarker have a backfill bit.
rescrv Nov 12, 2025
36feebb
propel review
rescrv Nov 12, 2025
8f5a60d
fix tests
rescrv Nov 12, 2025
f02f3b8
Adjust downward by the timeout the epoch passed into the backfill
rescrv Nov 15, 2025
6ba6a78
saturating_sub
rescrv Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions idl/chromadb/proto/logservice.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ message CollectionInfo {
int64 first_log_offset = 2;
// The timestamp of the first log entry of the collection that needs to be compacted
int64 first_log_ts = 3;
// If the request was the result of the backfill call---operator's intention left to the spurr of
// the moment.
bool backfill = 4;
Comment on lines +70 to +72
Copy link
Contributor

@propel-code-bot propel-code-bot bot Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Documentation]

This comment is a bit unclear and informal. A more descriptive comment would improve clarity for future developers. Also, there's a typo in "spurr".

Context for Agents 
[**Documentation**]

This comment is a bit unclear and informal. A more descriptive comment would improve clarity for future developers. Also, there's a typo in "spurr".

File: idl/chromadb/proto/logservice.proto
Line: 72

Copy link
Contributor Author

@rescrv rescrv Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want it murky so we can always repurpose backfill once we do this one.

}

message GetAllCollectionInfoToCompactRequest {
Expand Down Expand Up @@ -174,6 +177,14 @@ message FragmentToEvict {
message PurgeFromCacheResponse {
}

message BackfillRequest {
string collection_id = 1;
uint64 initial_insertion_epoch_us = 2;
Copy link
Contributor Author

@rescrv rescrv Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backfill will only trigger at this point.

}

message BackfillResponse {
}

service LogService {
rpc PushLogs(PushLogsRequest) returns (PushLogsResponse) {}
rpc ScoutLogs(ScoutLogsRequest) returns (ScoutLogsResponse) {}
Expand All @@ -200,4 +211,6 @@ service LogService {
// Similar to UpdateCollectionLogOffset, but allows the offset to go back in time.
// Uses the exact same request/response types as UpdateCollectionLogOffset by design.
rpc RollbackCollectionLogOffset(UpdateCollectionLogOffsetRequest) returns (UpdateCollectionLogOffsetResponse) {}
// Manually mark a request as dirty.
rpc Backfill(BackfillRequest) returns (BackfillResponse) {}
}
Loading
Loading