Remove aws provider config from module

[Roberdvs]

Hi!

I came across this module and while I was trying it out I found a problem with our current Terraform configuration because the aws provider is specified inside the module, so it prevents from configuring the provider in some other way in the parent module (like assuming a role).

I believe it would be a best practice to delegate the provider configuration to the parent module that calls this module and removing also the region and default_tags variables, let me know what you think!

Example usage that wasn't possible before:

provider "aws" {
  region = "eu-west-1"

  assume_role {
    role_arn = "arn:aws:iam::123456789:role/some-role"
  }

  default_tags {
    tags = {
	  project = "terraform-aws-organization-and-sso"
      management = "terraform"
    }
  }
}

module "aws_organizations_and_sso" {
	source  = "chris-qa-org/organzation-and-sso/aws"
	
	.
	.
}

[Stretch96]

Hi @Roberdvs,

Yep, you're completely right - I shouldn't have put the provider config in there 🤦‍♂️ ...

I tested it out, and fortunately it has no bad side effects when removing the provider block which it claims in the docs (https://www.terraform.io/language/modules/develop/providers):

As a consequence, you must ensure that all resources that belong to a particular provider configuration are destroyed before you can remove that provider configuration's block from your configuration. If Terraform finds a resource instance tracked in the state whose provider configuration block is no longer available then it will return an error during planning, prompting you to reintroduce the provider configuration.

I'll run the tests, merge, and version bump

Thanks for noticing and opening the PR 👍

[Roberdvs]

Thank you for accepting the PR!