Fixed key generation length #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jteich
commented
Sep 22, 2022
| # Generate a random key | ||
| def random_key(length=256) | ||
| _random_seed.unpack('H*')[0][0..((length/8)-1)] | ||
| _random_seed.unpack('H*')[0][0..((length/4)-1)] |
There was a problem hiding this comment.
The key as generated by _random_seed is a hex string. In a hex string, each character encodes 4 bits.
jteich
commented
Sep 22, 2022
| else | ||
| chars = ("a".."z").to_a + ("A".."Z").to_a + ("0".."9").to_a | ||
| (1..size).collect{|a| chars[rand(chars.size)] }.join | ||
| (1..size).collect{ rand(256).chr }.join |
There was a problem hiding this comment.
When using a modulo based upon a-z,A-Z,0-9 which comprises 62 characters, this effectively yields log2(62) (about 5.95) bits per character of randomness. rand(256) will yield a full 8 bits per character, inline with what OpenSSL::Random.random_bytes would return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.