Cache parquet schema fields & update libchdb #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0und0fs1lence
changed the title
auxten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids the costly call of
ColumnTypeDatabaseTypeNamefunction in the hotpat of theNextmethod.the schema of the parquet will never change during the Next() call untill the cursor is alive; so we just calculate them in the
PrepareRowsandPrepareStreamingRowsto avoid a heap allocation for the slice of the fields on each iteration.This overhead could lead to GC pressure in big datasets and thus decreasing the performance of the entire driver.
Also, i've bumped libchdb to the latest version, and start using the new API