Skip to content

Conversation

@sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Oct 20, 2022

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • I wrote a unit test about the implementation.
  • I wrote a storybook document about the implementation.
  • I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox ❌
    • macOS: Chrome, Edge, Safari, (Optional) Firefox ✅

Related Issue

없음

Summary

  • 폼 유즈 케이스에서 라벨 컴포넌트의 영역이 150px로 고정되어있는걸 확인했습니다. FormControl 의 불필요한 minmax 스타일을 제거하고 고정 너비로 변경합니다.
  • FormLabel 컴포넌트의 text-overflow를 방지하기 위해 word-break: break-word 스타일을 추가하고, Help 컴포넌트와 함께 사용될 경우도 마찬가지로 flex-shrink 속성을 추가합니다.

Details

라벨이 길 경우 아래와 같이 줄넘김 처리가 됩니다.

AS-IS

스크린샷 2022-10-20 오후 9 17 19

TO-BE

스크린샷 2022-10-21 오후 12 06 30

Breaking change or not (Yes/No)

No

References

@sungik-choi sungik-choi self-assigned this Oct 20, 2022
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2022

🦋 Changeset detected

Latest commit: 9223cd5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sungik-choi sungik-choi added the enhancement Issues or PR related to making existing features better label Oct 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022

Chromatic Report

🚀 Congratulations! Your build was successful!

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 71.08% // Head: 71.08% // No change to project coverage 👍

Coverage data is based on head (5a650aa) compared to base (a2759dc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1     #937   +/-   ##
========================================
  Coverage    71.08%   71.08%           
========================================
  Files          206      206           
  Lines         2902     2902           
  Branches       810      810           
========================================
  Hits          2063     2063           
  Misses         721      721           
  Partials       118      118           
Impacted Files Coverage Δ
...components/Forms/FormControl/FormControl.styled.ts 100.00% <ø> (ø)
...src/components/Forms/FormLabel/FormLabel.styled.ts 100.00% <ø> (ø)
...react/src/components/Forms/FormLabel/FormLabel.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@CHEWCHEWW CHEWCHEWW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존 사용이 불편했던 부분이라 스펙이 통일돼서 좋네요 🥳

export const Label = styled(Text)`
display: block;
text-align: left;
word-break: break-all;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break-all은 영어의 경우에 어색해서 기피하는 것 같던데, 언어 specific한 고려를 bezier에서 하는 것도 어색해서 고민이네요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#924 와 시안을 고려해봤을 때 break-word 로 변경하는 게 적절해보입니다.

@sungik-choi sungik-choi merged commit bb8a978 into channel-io:next-v1 Oct 21, 2022
@sungik-choi sungik-choi deleted the enhance/form-controls branch October 21, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issues or PR related to making existing features better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants