-
Notifications
You must be signed in to change notification settings - Fork 52
Enhance FormControl and FormLabel style to avoid text-overflow #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance FormControl and FormLabel style to avoid text-overflow #937
Conversation
🦋 Changeset detectedLatest commit: 9223cd5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chromatic Report🚀 Congratulations! Your build was successful! |
Codecov ReportBase: 71.08% // Head: 71.08% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #937 +/- ##
========================================
Coverage 71.08% 71.08%
========================================
Files 206 206
Lines 2902 2902
Branches 810 810
========================================
Hits 2063 2063
Misses 721 721
Partials 118 118
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
CHEWCHEWW
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기존 사용이 불편했던 부분이라 스펙이 통일돼서 좋네요 🥳
| export const Label = styled(Text)` | ||
| display: block; | ||
| text-align: left; | ||
| word-break: break-all; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
break-all은 영어의 경우에 어색해서 기피하는 것 같던데, 언어 specific한 고려를 bezier에서 하는 것도 어색해서 고민이네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#924 와 시안을 고려해봤을 때 break-word 로 변경하는 게 적절해보입니다.
Self Checklist
Related Issue
없음
Summary
FormControl의 불필요한minmax스타일을 제거하고 고정 너비로 변경합니다.FormLabel컴포넌트의 text-overflow를 방지하기 위해word-break: break-word스타일을 추가하고, Help 컴포넌트와 함께 사용될 경우도 마찬가지로flex-shrink속성을 추가합니다.Details
라벨이 길 경우 아래와 같이 줄넘김 처리가 됩니다.
AS-IS
TO-BE
Breaking change or not (Yes/No)
No
References