Skip to content

Conversation

@aooen
Copy link
Contributor

@aooen aooen commented Oct 17, 2022

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • I wrote a unit test about the implementation.
  • I wrote a storybook document about the implementation.
  • I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

It reduce many whitespace of component style code in compiled source like this:

as-is to-be
스크린샷 2022-10-17 오후 6 58 25 스크린샷 2022-10-17 오후 6 42 35

Size diff:

as-is to-be
스크린샷 2022-10-17 오후 4 18 19 스크린샷 2022-10-17 오후 6 53 20
스크린샷 2022-10-17 오후 3 52 09 스크린샷 2022-10-17 오후 6 47 09

Details

  • Migrate typescript-plugin-styled-components to babel-plugin-styled-components for apply minify(for remove extra whitespace), pure(for remove dead code).

    There is minify option at typescript-plugin-styled-components, but that's not work for me. (maybe influence of FoundationStyledComponent's override)

  • Hide comment on style code that's not removed automatically by minify

Breaking change or not (Yes/No)

  • No breaking change.

References

@aooen aooen added the refactoring Issue or PR related to refactoring with no functional changes label Oct 17, 2022
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022

🦋 Changeset detected

Latest commit: 59584ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 71.15% // Head: 71.15% // No change to project coverage 👍

Coverage data is based on head (59584ee) compared to base (d90c27a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1     #934   +/-   ##
========================================
  Coverage    71.15%   71.15%           
========================================
  Files          208      208           
  Lines         2961     2961           
  Branches       821      821           
========================================
  Hits          2107     2107           
  Misses         736      736           
  Partials       118      118           
Impacted Files Coverage Δ
.../Avatars/CheckableAvatar/CheckableAvatar.styled.ts 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link
Contributor

@sungik-choi sungik-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

애플리케이션 런타임에서 잘 동작하나요? (FYI. #752)

@aooen
Copy link
Contributor Author

aooen commented Oct 18, 2022

애플리케이션 런타임에서 잘 동작하나요? (FYI. #752)

음 저는 딱히 문제는 없습니다. withConfig 쓰는건 typescript-plugin-styled-components도 마찬가지인데, 이건 FoundationStyledComponent.tsx 고치셨던 걸로 잘 동작하게 된 것 같습니다.

@sungik-choi sungik-choi added chore:deps Issue or PR related to dependencies build Issue or PR related to build system labels Nov 9, 2022
@aooen aooen merged commit 650d31b into channel-io:next-v1 Nov 14, 2022
leejiwoo2002 added a commit to leejiwoo2002/bezier-react that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issue or PR related to build system chore:deps Issue or PR related to dependencies refactoring Issue or PR related to refactoring with no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants