-
Notifications
You must be signed in to change notification settings - Fork 52
Reduce bundle size (apply minify for styled-components) #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce bundle size (apply minify for styled-components) #934
Conversation
🦋 Changeset detectedLatest commit: 59584ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 71.15% // Head: 71.15% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #934 +/- ##
========================================
Coverage 71.15% 71.15%
========================================
Files 208 208
Lines 2961 2961
Branches 821 821
========================================
Hits 2107 2107
Misses 736 736
Partials 118 118
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Chromatic Report🚀 Congratulations! Your build was successful! |
sungik-choi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
애플리케이션 런타임에서 잘 동작하나요? (FYI. #752)
음 저는 딱히 문제는 없습니다. withConfig 쓰는건 typescript-plugin-styled-components도 마찬가지인데, 이건 FoundationStyledComponent.tsx 고치셨던 걸로 잘 동작하게 된 것 같습니다. |
…nel-io#934)" This reverts commit 650d31b.
Self Checklist
I wrote a unit test about the implementation.I wrote a storybook document about the implementation.Related Issue
Summary
It reduce many whitespace of component style code in compiled source like this:
Size diff:
Details
Breaking change or not (Yes/No)
References