Skip to content

Conversation

@guswnsxodlf
Copy link
Contributor

@guswnsxodlf guswnsxodlf commented Aug 2, 2022

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • I wrote a unit test about the implementation.
  • I wrote a storybook document about the implementation.
  • I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Fixes #0000

Summary

This PR adds a floating-alt style variant in Button element.

Details

Screenshot 2022-08-02 at 21 12 31

Breaking change or not (Yes/No)

No

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2022

🦋 Changeset detected

Latest commit: ad4a873

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@guswnsxodlf guswnsxodlf self-assigned this Aug 2, 2022
@guswnsxodlf guswnsxodlf added the design update Issue or PR that Up-to-date specifications for design system updates label Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #907 (ad4a873) into next-v1 (545a18c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           next-v1     #907      +/-   ##
===========================================
+ Coverage    69.25%   69.29%   +0.04%     
===========================================
  Files          203      203              
  Lines         2859     2863       +4     
  Branches       792      792              
===========================================
+ Hits          1980     1984       +4     
  Misses         767      767              
  Partials       112      112              
Impacted Files Coverage Δ
...ezier-react/src/components/Button/Button.styled.ts 92.64% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 545a18c...ad4a873. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi
Copy link
Contributor

PR Checklist의 add changeset도 확인 부탁드립니다!

@guswnsxodlf guswnsxodlf requested a review from sungik-choi August 3, 2022 04:50
Copy link
Contributor

@inhibitor1217 inhibitor1217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation - API section에 수정사항 반영해주세요.

@guswnsxodlf guswnsxodlf force-pushed the features/add-floating-alt branch from 5cde1d2 to ad4a873 Compare August 3, 2022 05:05
@guswnsxodlf guswnsxodlf merged commit af5cb6f into channel-io:next-v1 Aug 3, 2022
@guswnsxodlf guswnsxodlf deleted the features/add-floating-alt branch August 3, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design update Issue or PR that Up-to-date specifications for design system updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants