-
Notifications
You must be signed in to change notification settings - Fork 52
fix(form-group): apply default value of justify-content, align-items property #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e0aa54a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chromatic Report🚀 Congratulations! Your build was successful! |
Codecov Report
@@ Coverage Diff @@
## next-v1 #901 +/- ##
========================================
Coverage 69.01% 69.01%
========================================
Files 205 205
Lines 2872 2872
Branches 791 791
========================================
Hits 1982 1982
Misses 775 775
Partials 115 115
Continue to review full report at Codecov.
|
Seolhun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changeset 커밋이 마지막에 가야하지 않을까 싶네요. squash라 상관없겠지만요.
inhibitor1217
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stack 인터페이스를 변경할 수도 있지만 breaking change 마이그레이션 비용도 고려가 필요합니다.
Discussion에서 얘기를 해 볼 수 있다고 생각합니다.
이 PR의 diff는 기존의 behavior를 복원하는 fix이기 때문에 괜찮습니다
quino0627
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR 머지되고 나면 데스크 대응 필요한 부분 수정하게 핑 주세요~ @sungik-choi
Self Checklist
Related Issue
없음
Summary
FormGroup컴포넌트의 동작을 #866 이전과 동일하게 맞추기 위해, CSS Flex 프로퍼티 기본 값과 동일하게 세팅합니다.Details
What are the default values for justify-content & align content?
위를 참고하여,
justify-content의 경우flex-start를 기본값으로,align-items의 경우stretch를 기본값으로 하도록 변경합니다.Stack의 align 속성의 기본값을 마찬가지로flex-start에서justify-content로 변경하는 걸 제안해봅니다. 사용하다보니, 특히VStack의 경우justify="stretch"속성을 주는 경우가 굉장히 빈번했었습니다. 다른 분들의 의견도 궁금합니다. (FYI @inhibitor1217)Breaking change or not (Yes/No)
No
References