Skip to content

Conversation

@Seolhun
Copy link
Contributor

@Seolhun Seolhun commented Jul 25, 2022

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • I wrote a unit test about the implementation.
  • I wrote a storybook document about the implementation.
  • I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Summary

  • remove fixed height(28px) styles
  • add default color to value component

Details

  • add color(txt/black/darkest) style to value component
  • remove fixed height(28px) style
  • change align-items "center" to "flex-start"

Screen Shot 2022-07-25 at 11 51 18

Browser Compatibility

OS / Engine 호환성을 반드시 확인해주세요.

Windows

  • Chrome - Blink
  • Edge - Blink
  • Firefox - Gecko (Option)

macOS

  • Chrome - Blink
  • Edge - Blink
  • Safari - WebKit
  • Firefox - Gecko (Option)

References

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2022

🦋 Changeset detected

Latest commit: f587a8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #896 (f587a8e) into next-v1 (fa97b85) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           next-v1     #896      +/-   ##
===========================================
+ Coverage    69.01%   69.02%   +0.01%     
===========================================
  Files          205      205              
  Lines         2872     2873       +1     
  Branches       791      791              
===========================================
+ Hits          1982     1983       +1     
  Misses         775      775              
  Partials       115      115              
Impacted Files Coverage Δ
...KeyValueListItem/KeyValueListItem.common.styled.ts 100.00% <ø> (ø)
...onents/KeyValueListItem/KeyValueListItem.styled.ts 100.00% <ø> (ø)
...ValueListItem/common/ValueItem/ValueItem.styled.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa97b85...f587a8e. Read the comment docs.

@Seolhun Seolhun self-assigned this Jul 25, 2022
@Seolhun Seolhun requested a review from quino0627 July 25, 2022 06:38
@Seolhun Seolhun marked this pull request as ready for review July 25, 2022 06:38
@Seolhun
Copy link
Contributor Author

Seolhun commented Jul 25, 2022

https://desk.channel.io/root/threads/groups/(TF)BezierReactV1-124831/62de2149021de8178840/62de2149021de8178840

이러한 이유로 desk에서 pack을 테스트하지는 못하였습니다.
우선순위가 지금 높지 않아 기다려보고 안되면 마이그레이션 진행할게요.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2022

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link
Contributor

@sungik-choi sungik-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마이그레이션 제가 하고 핑 드리겠습니다!

  • changeset을 추가해주세요(영문)! semantic-release에서 changeset으로 변경하면서, 커밋으로 릴리즈 노트를 자동으로 생성해주지 않기 때문에 버전업에 관련된 변경사항에 대해 개발자가 직접 추가해주어야합니다.
  • PR 제목을 영문으로 변경해주시면 감사하겠습니다 🙏 오픈소스임을 고려해서 PR 제목 등은 영문으로 작성하는 방식으로 맞추려고 해요(#895)

@Seolhun
Copy link
Contributor Author

Seolhun commented Jul 26, 2022

  • change commit message in english
  • change pr title in english

@Seolhun Seolhun changed the title SingleKeyValueListItem의 스타일 개선 refactor(key-value-list-item): change key and value component styles removed fixed height and given default color Jul 26, 2022
@Seolhun Seolhun added refactoring Issue or PR related to refactoring with no functional changes fix PR related to bug fix labels Jul 26, 2022
@sungik-choi
Copy link
Contributor

yarn changeset 커맨드로 변경사항에 대한 changelog만 추가해주시면 될 거 같습니다!

@Seolhun Seolhun requested a review from sungik-choi July 26, 2022 04:35
@Seolhun Seolhun merged commit 6d07015 into channel-io:next-v1 Jul 26, 2022
@Seolhun Seolhun deleted the bugfix/keyvalue branch July 26, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix PR related to bug fix refactoring Issue or PR related to refactoring with no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants